-
Notifications
You must be signed in to change notification settings - Fork 818
Es/taskify reexecution #4435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Elvis339
wants to merge
31
commits into
master
Choose a base branch
from
es/taskify-reexecution
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Es/taskify reexecution #4435
Changes from all commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
1e7faf0
chore: add c-chain-reexecution benchmark as concrete tasks
Elvis339 bf4fb7f
ci(c-chain-reexecution):
Elvis339 2d94d69
ci(c-chain-reexecution): replace `fromJSON` construction
Elvis339 7e4e52c
Merge branch 'master' into es/taskify-reexecution
Elvis339 d4f2f1b
ci(c-chain-reexecution): set correct config json path
Elvis339 52e17c8
test-ci(c-chain-reexecution): set correct config json path
Elvis339 f28890f
test-ci(c-chain-reexecution): switch back to `fromJSON` construction
Elvis339 48e272d
ci(c-chain-reexecution-benchmark)
Elvis339 0fcb8f4
Merge branch 'master' into es/taskify-reexecution
Elvis339 58075af
ci(c-chain-reexecution-benchmark): add `c-chain-reexecution-hashdb-10…
Elvis339 0a8a6e3
lint
Elvis339 af32912
ci(c-chain-reexecution-benchmark): install xz-utils on self-hosted ru…
Elvis339 581c2d1
ci(c-chain-reexecution-benchmark): remove `FILTER_BY_OWNER` from `Sho…
Elvis339 e44dfc4
test-ci(c-chain-reexecution-benchmark): upload benchmark results
Elvis339 3f1166b
ci(c-chain-reexecution-benchmark): fix missing benchmark file path in…
Elvis339 e5dc324
ci(c-chain-reexecution-benchmark): fix missing benchmark file path in…
Elvis339 bca25cc
ci(c-chain-reexecution-benchmark): fix missing benchmark file path in…
Elvis339 5e2c482
ci(c-chain-reexecution-benchmark): fix missing benchmark file path in…
Elvis339 e28693c
ci(c-chain-reexecution-benchmark): fix missing benchmark file path in…
Elvis339 73bbaa6
ci(c-chain-reexecution-benchmark): simplify workspace handling and fi…
Elvis339 098871b
ci(c-chain-reexecution-benchmark): simplify workspace handling and fi…
Elvis339 5664f93
ci(c-chain-reexecution-benchmark)
Elvis339 670500a
Merge branch 'master' into es/taskify-reexecution
Elvis339 4ead15b
co-pilot pr review
Elvis339 b9ae96f
Merge remote-tracking branch 'origin/es/taskify-reexecution' into es/…
Elvis339 5236925
ci(c-chain-reexecution-benchmark)
Elvis339 7c754ed
Merge remote-tracking branch 'origin/es/taskify-reexecution' into es/…
Elvis339 3020b86
ci(c-chain-reexecution-benchmark): set `BENCHMARK_OUTPUT_FILE` to `ou…
Elvis339 33c73c3
chore: configure one known variable per run of c-chain-reexecution-* …
Elvis339 2b67612
address pr
Elvis339 0635d05
chore: handle copy_dir.sh s3 path
Elvis339 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
35 changes: 35 additions & 0 deletions
35
.github/actions/c-chain-reexecution-benchmark/nix-develop.sh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| #!/usr/bin/env bash | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What's the rational for this addition? |
||
|
|
||
| set -euo pipefail | ||
|
|
||
| if [[ -f "flake.nix" ]]; then | ||
| echo "Starting nix shell for local flake" | ||
| FLAKE= | ||
| else | ||
| echo "No local flake found, will attempt to use avalanchego flake" | ||
|
|
||
| # Get module details from go.mod | ||
| MODULE_DETAILS="$(go list -m "github.com/ava-labs/avalanchego" 2>/dev/null)" | ||
|
|
||
| # Extract the version part | ||
| AVALANCHE_VERSION="$(echo "${MODULE_DETAILS}" | awk '{print $2}')" | ||
|
|
||
| if [[ -z "${AVALANCHE_VERSION}" ]]; then | ||
| echo "Failed to get avalanchego version from go.mod" | ||
| exit 1 | ||
| fi | ||
|
|
||
| # Check if the version matches the pattern where the last part is the module hash | ||
| # v*YYYYMMDDHHMMSS-abcdef123456 | ||
| # | ||
| # If not, the value is assumed to represent a tag | ||
| if [[ "${AVALANCHE_VERSION}" =~ ^v.*[0-9]{14}-[0-9a-f]{12}$ ]]; then | ||
| # Use the module hash as the version | ||
| AVALANCHE_VERSION="$(echo "${AVALANCHE_VERSION}" | cut -d'-' -f3)" | ||
| fi | ||
|
|
||
| FLAKE="github:ava-labs/avalanchego?ref=${AVALANCHE_VERSION}" | ||
| echo "Starting nix shell for ${FLAKE}" | ||
| fi | ||
|
|
||
| nix develop "${FLAKE}" "${@}" | ||
1 change: 1 addition & 0 deletions
1
.github/actions/c-chain-reexecution-benchmark/output-metrics-url.sh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| ../run-monitored-tmpnet-cmd/output-metrics-url.sh |
46 changes: 46 additions & 0 deletions
46
.github/workflows/c-chain-reexecution-benchmark-config.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| { | ||
| "pull_request": { | ||
| "include": [ | ||
| { | ||
| "task": "c-chain-reexecution-hashdb-101-250k", | ||
| "runner": "ubuntu-latest", | ||
| "self_hosted": false, | ||
| "timeout-minutes": 30 | ||
| }, | ||
| { | ||
| "task": "c-chain-reexecution-hashdb-101-250k", | ||
| "runner": "avalanche-avalanchego-runner-2ti", | ||
| "self_hosted": true, | ||
| "timeout-minutes": 30 | ||
| }, | ||
| { | ||
| "task": "c-chain-reexecution-hashdb-archive-101-250k", | ||
| "runner": "blacksmith-4vcpu-ubuntu-2404", | ||
| "self_hosted": false, | ||
| "timeout-minutes": 30 | ||
| }, | ||
| { | ||
| "task": "c-chain-reexecution-hashdb-101-250k", | ||
| "runner": "blacksmith-4vcpu-ubuntu-2404", | ||
| "self_hosted": false, | ||
| "timeout-minutes": 30 | ||
| } | ||
| ] | ||
| }, | ||
| "schedule": { | ||
| "include": [ | ||
| { | ||
| "task": "c-chain-reexecution-hashdb-33m-33m500k", | ||
| "runner": "avago-runner-m6i-4xlarge-ebs-fast", | ||
| "self_hosted": true, | ||
| "timeout-minutes": 1440 | ||
| }, | ||
| { | ||
| "task": "c-chain-reexecution-hashdb-33m-33m500k", | ||
| "runner": "avago-runner-i4i-4xlarge-local-ssd", | ||
| "self_hosted": true, | ||
| "timeout-minutes": 1440 | ||
| } | ||
| ] | ||
| } | ||
| } |
46 changes: 0 additions & 46 deletions
46
.github/workflows/c-chain-reexecution-benchmark-container.json
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.