cache signatures only in acp118 handler #3474
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
network/p2p/acp118/handler_test.go
Outdated
Comment on lines
129
to
134
| if tt.cacher.Len() > 0 { | ||
| // Ensure the cache is populated with correct signature | ||
| sig, ok := tt.cacher.Get(unsignedMessage.ID()) | ||
| require.True(ok) | ||
| require.Equal(sig, response.Signature) | ||
| } |
There was a problem hiding this comment.
Rather than checking the length (which seems fairly fragile) we should just assert that the signature is as expected if the cacher returns the signature.
network/p2p/acp118/handler.go
Outdated
| return responseBytesFromSignature(signature) | ||
| } | ||
|
|
||
| func responseBytesFromSignature(signature []byte) ([]byte, *common.AppError) { |
There was a problem hiding this comment.
Suggested change
| func responseBytesFromSignature(signature []byte) ([]byte, *common.AppError) { | |
| func signatureToResponse(signature []byte) ([]byte, *common.AppError) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Cache might be needed to shared with other components. Currently we cache whole proto signature response, a plain signature caching can be more straightforward to be returned from shared cache for other components.
For instance Subnet-EVM can use this signature cache in API calls and in legacy p2p handler.
How this works
Caches and returns direct signature bytes rather than proto
SignatureResponseHow this was tested
Added UT