Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tmpnet] Add --start-network to support hypersdk MODE=run #3465

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

marun
Copy link
Contributor

@marun marun commented Oct 11, 2024

Why this should be merged

Hypersdk tooling has long supported supplying MODE=run to its run.sh script to start a network and leave it running without executing any tests. When hypersdk switched to tmpnet, the run script was updated to specify --reuse-network and run a trivial test, but the use of --reuse-network risks confusion if a user expects the resulting network to reflect the latest binary state. Adding explicit support for always starting a new network avoids this risk.

How this works

  • Add new flag --start-network to the tmpnet env flags
  • If the flag is provided, start a new network, avoid stopping it on cleanup, and exist before running any tests

How this was tested

CI for regression, locally to check that a new network was started and stayed running

@marun marun added the testing This primarily focuses on testing label Oct 11, 2024
@marun marun self-assigned this Oct 11, 2024
Copy link
Collaborator

@aaronbuchwald aaronbuchwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing This primarily focuses on testing
Projects
Status: Backlog 🗄️
Development

Successfully merging this pull request may close these issues.

2 participants