change host to node #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sukantoraymond
commented
Jun 25, 2024
sukantoraymond
commented
Jun 25, 2024
Comment on lines
+43
to
+72
| type Node struct { | ||
| // NodeID is Avalanche Node ID of the node | ||
| NodeID string | ||
|
|
||
| // IP address of the host | ||
| // IP address of the node | ||
| IP string | ||
|
|
||
| // SSH configuration for the host | ||
| // SSH configuration for the node | ||
| SSHConfig SSHConfig | ||
|
|
||
| // Cloud configuration for the host | ||
| // Cloud is the cloud service that the node is on | ||
| // Full list of cloud service: | ||
| // - AWS | ||
| // - GCP | ||
| // - Docker | ||
| Cloud SupportedCloud | ||
|
|
||
| // CloudConfig is the cloud specific configuration for the host | ||
| // CloudConfig is the cloud specific configuration for the node | ||
| CloudConfig CloudParams | ||
|
|
||
| // Connection to the host | ||
| Connection *goph.Client | ||
| // connection to the node | ||
| connection *goph.Client | ||
|
|
||
| // Roles of the host | ||
| // Roles of the node | ||
| // Full list of node roles: | ||
| // - Validator | ||
| // - API | ||
| // - AWM Relayer | ||
| // - Load Test | ||
| // - Monitoring |
There was a problem hiding this comment.
Added more description to node
sukantoraymond
commented
Jun 25, 2024
sukantoraymond
commented
Jun 25, 2024
Comment on lines
-18
to
-20
| // Name of the node | ||
| Name string | ||
|
|
There was a problem hiding this comment.
removing name
sukantoraymond
commented
Jun 25, 2024
Comment on lines
-30
to
-31
| // Static IP of the node | ||
| StaticIP string |
There was a problem hiding this comment.
removing static ip, note: need to complete #82 otherwise create node on gcp will not work
sukantoraymond
commented
Jun 25, 2024
sukantoraymond
commented
Jun 25, 2024
arturrez
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.