Skip to content

Refactor Test Block BlockBuilder #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 4, 2025
Merged

Refactor Test Block BlockBuilder #304

merged 4 commits into from
Dec 4, 2025
+199 −234

Conversation

@samliok
Copy link
Collaborator

@samliok samliok commented Dec 1, 2025 •
edited
Loading

Couple of benefits

  • Easier to understand the TestBlockBuilder API.
  • Caller does not need to worry about the inner fields of TestBlockBuilder.

@samliok samliok marked this pull request as ready for review December 1, 2025 19:03
yacovm
yacovm reviewed Dec 1, 2025
View reviewed changes
yacovm
yacovm reviewed Dec 3, 2025
View reviewed changes
yacovm
yacovm reviewed Dec 3, 2025
View reviewed changes
@yacovm
Copy link
Collaborator

yacovm commented Dec 3, 2025

LGTM modulo comments

@yacovm
Copy link
Collaborator

yacovm commented Dec 4, 2025 

TestEpochLeaderFailoverWithEmptyNotarization (9m46s)

Looks like it hanged

@yacovm
Copy link
Collaborator

yacovm commented Dec 4, 2025 


github.com/ava-labs/simplex/testutil.(*TestBlockBuilder).GetBuiltBlock(0xc0001a3c30)
	/home/runner/work/Simplex/Simplex/testutil/block_builder.go:57 +0x1a5
github.com/ava-labs/simplex_test.advanceRound(0xc00011f380, 0xc00013a008, 0xc0001a3c30, 0x1, 0x1, 0x0)
	/home/runner/work/Simplex/Simplex/epoch_test.go:1353 +0x578
github.com/ava-labs/simplex_test.notarizeAndFinalizeRound(...)
	/home/runner/work/Simplex/Simplex/epoch_test.go:762
github.com/ava-labs/simplex_test.TestEpochLeaderFailoverWithEmptyNotarization(0xc00011f380)

Can it be related to this PR?

@samliok samliok merged commit 7a57f35 into main Dec 4, 2025
5 checks passed
@samliok samliok deleted the test-bb branch December 4, 2025 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yacovm yacovm yacovm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@samliok @yacovm