-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lanelet2_map_validator): add validator to check traffic light facing #165
Open
TaikiYamada4
wants to merge
11
commits into
autowarefoundation:main
Choose a base branch
from
TaikiYamada4:feat/lanelet2_map_validator/add_traffic_light_facing
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(lanelet2_map_validator): add validator to check traffic light facing #165
TaikiYamada4
wants to merge
11
commits into
autowarefoundation:main
from
TaikiYamada4:feat/lanelet2_map_validator/add_traffic_light_facing
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: TaikiYamada4 <[email protected]>
Signed-off-by: TaikiYamada4 <[email protected]>
Signed-off-by: TaikiYamada4 <[email protected]>
Signed-off-by: TaikiYamada4 <[email protected]>
…raffic_lights Signed-off-by: TaikiYamada4 <[email protected]>
Added test for TrafficLight.CorrectFacing-001 Signed-off-by: TaikiYamada4 <[email protected]>
Signed-off-by: TaikiYamada4 <[email protected]>
TaikiYamada4
requested review from
anhnv3991,
soblin,
Motsu-san,
SakodaShintaro and
YamatoAndo
as code owners
November 27, 2024 02:19
Signed-off-by: TaikiYamada4 <[email protected]>
TaikiYamada4
added
tag:run-build-and-test-differential
and removed
tag:run-build-and-test-differential
labels
Nov 27, 2024
Signed-off-by: TaikiYamada4 <[email protected]>
Signed-off-by: TaikiYamada4 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The facing of the traffic lights are defined by its linestring direction.
This PR adds a validator
mapping.traffic_light.correct_facing
that checks whether the traffic light is facing correctly.Besides, I also added a validator
mapping.traffic_light.missing_referrers
that checks thetraffic_light
type regulatory element is referred by lanelets because the traffic light facing validation requires them and it is also required in the Autoware vector map requirements.In short, this PR adds the following implementation.
mapping.traffic_light.missing_referrers
that detectstraffic_light
type regulatory elements that are NOT referred by lanelets.mapping.traffic_light.correct_facing
that detects wrong traffic light facing.mapping.traffic_light.missing_referrers
andmapping.traffic_light.correct_facing
.mapping.traffic_light.missing_referrers
andmapping.traffic_light.correct_facing
.autoware_requirement_set.json
autoware_requirement_set.json
. (The crosswalk and traffic light were on the opposite side)Related links
None
Tests performed
colcon test --packages-select autoware_lanelet2_map_validator --event-handlers console_cohesion+
passes.Notes for reviewers
Please take a look at
traffic_light_facing.md
for further understandings to the algorithm of it.Interface changes
None
Effects on system behavior
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.