-
Notifications
You must be signed in to change notification settings - Fork 149
bug fix about issue #5 #6
base: master
Are you sure you want to change the base?
bug fix about issue #5 #6
Conversation
Signed-off-by: Tasaki-Lab <[email protected]>
2269488
to
347a746
Compare
costmap_generator/nodes/costmap_generator/points_to_costmap.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Tasaki-Lab <[email protected]>
…Tasaki-Lab/core_planning into core_planning_Tasaki-Lab_branch Signed-off-by: Tasaki-Lab <[email protected]>
2ee7882
to
e3aebd1
Compare
Signed-off-by: Tasaki-Lab <[email protected]>
67431ad
to
2dc4143
Compare
@Tasaki-Lab It appears that this change intermittently causes a segmentation fault. Can you please try keeping the |
I think isValidInd has a bug. In GridMap::setGeometry, the size of cost map is defined as: So, I modify the code. (Tested by Moriyama data) |
Signed-off-by: Tasaki-Lab <[email protected]>
f8625d0
to
a7cfc17
Compare
@Tasaki-Lab Where are you seeing the code that you're talking about? Can you provide a link? I don't see any |
Autoware uses grid_map_ros provided by ROS package, right? costmap_generator.cpp (line 124) uses setGeometry provided by the ROS package. |
Bug fix
Fixed bug
I fix the bug about issue 5.
#5
Fix applied
Grids of the cost map generated by costmap_generator are not placed correctlly.
For example, maybe, we want the point's position (0.3, 0.5) in the costmap coordinate to be placed cost map index (0, 0).
In the case of previous code:
the position (0.3, 0.5) -> cost map index (1, 1)
New feature implementation
the position (0.3, 0.5) -> cost map index (0, 0)
Implemented feature
int mapped_x_ind = std::ceil(mapped_x);
-->
int mapped_x_ind = (int)mapped_x;