Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(.git): delete -amd64 and -arm64 image tags after pushing manifest #5526

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat(.git): delete -amd64 and -arm64 image tags after pushing manifest #5526

wants to merge 3 commits into from

Conversation

youtalk
Copy link
Member

@youtalk youtalk commented Dec 3, 2024 •
edited
Loading

Description

This PR deletes the -amd64 and -arm64 image tags after the manifest for the multi-architecture image has been pushed.

How was this PR tested?

Notes for reviewers

None.

Effects on system behavior

None.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 3, 2024 •
edited
Loading

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@youtalk youtalk self-assigned this Dec 3, 2024
@youtalk youtalk added type:containers Docker containers, containerization of components, or container orchestration. component:openadkit Issues or Features related to Open AD Kit tag:run-health-check Run health-check labels Dec 3, 2024
@youtalk youtalk marked this pull request as ready for review December 3, 2024 01:42
@mitsudome-r
Copy link
Member

Are there any reasons for deleting the tag? I thought we can keep it even if after the manifest is pushed.

@youtalk
Copy link
Member Author

youtalk commented Dec 3, 2024

@mitsudome-r It’s simply a matter of consistency. I found it personally unsettling to see a lot of multi-architecture images alongside single-architecture images with suffixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmfcx xmfcx Awaiting requested review from xmfcx

@mitsudome-r mitsudome-r Awaiting requested review from mitsudome-r

@oguzkaganozt oguzkaganozt Awaiting requested review from oguzkaganozt oguzkaganozt is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@youtalk youtalk

Labels
component:openadkit Issues or Features related to Open AD Kit tag:run-health-check Run health-check type:containers Docker containers, containerization of components, or container orchestration.
Projects
Open AD Kit Working Group
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@youtalk @mitsudome-r