ci(sync-files): make use of sync-files-templates repo #5504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: M. Fatih Cırıt <[email protected]>
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Signed-off-by: M. Fatih Cırıt <[email protected]>
Signed-off-by: M. Fatih Cırıt <[email protected]>
Closed
|
Ready for review ✅ |
mitsudome-r
approved these changes
Nov 29, 2024
youtalk
added a commit
to youtalk/autoware
that referenced
this pull request
Nov 29, 2024
* feat(docker): inherit `autoware-base` images (autowarefoundation#5492) * change run Signed-off-by: Yutaka Kondo <[email protected]> * use autoware-base images Signed-off-by: Yutaka Kondo <[email protected]> * update health-check Signed-off-by: Yutaka Kondo <[email protected]> * update load-env Signed-off-by: Yutaka Kondo <[email protected]> * update load-env Signed-off-by: Yutaka Kondo <[email protected]> * fix rebase Signed-off-by: Yutaka Kondo <[email protected]> * add build-args Signed-off-by: Yutaka Kondo <[email protected]> * fix hcl Signed-off-by: Yutaka Kondo <[email protected]> --------- Signed-off-by: Yutaka Kondo <[email protected]> * chore(autoware.repos): fix `autoware.universe` and `autoware_launch` versions to `0.39.0` (autowarefoundation#5479) * ci: update the pr template and add comment-on-pr workflow (autowarefoundation#5500) Signed-off-by: M. Fatih Cırıt <[email protected]> * ci(spell-check): switch the repository to autowarefoundation (autowarefoundation#5501) Signed-off-by: M. Fatih Cırıt <[email protected]> * ci(pre-commit-ansible): autoupdate (autowarefoundation#5217) Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions <[email protected]> * ci(spell-check-diff): add explicit dict-packages (autowarefoundation#5503) Signed-off-by: M. Fatih Cırıt <[email protected]> * refactor(docker): fix `Dockerfile` indent (autowarefoundation#5495) fix indent Signed-off-by: Yutaka Kondo <[email protected]> * feat(docker): update cleanup scripts (autowarefoundation#5497) * update cleanup scripts Signed-off-by: Yutaka Kondo <[email protected]> * revert to ubuntu-22.04 Signed-off-by: Yutaka Kondo <[email protected]> --------- Signed-off-by: Yutaka Kondo <[email protected]> * ci(sync-files): make use of sync-files-templates repo (autowarefoundation#5504) Signed-off-by: M. Fatih Cırıt <[email protected]> --------- Signed-off-by: Yutaka Kondo <[email protected]> Signed-off-by: M. Fatih Cırıt <[email protected]> Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: M. Fatih Cırıt <[email protected]> Co-authored-by: awf-autoware-bot[bot] <94889083+awf-autoware-bot[bot]@users.noreply.github.com> Co-authored-by: github-actions <[email protected]>
29 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Parent issue:
Reference: https://github.com/autowarefoundation/sync-file-templates
Before this PR, many sync-file configs make use of this autoware, archived autoware_common and autoware-documentation repositories as the source of their basic files.
Starting with this PR, I plan to make use of only a single source file for the sync-files called https://github.com/autowarefoundation/sync-file-templates
This repository was created by @isamu-takagi -san for this purpose.
I've updated it and want to keep using across autoware repositories.
Changes
This PR specifically generates the following changes:
PR template
Simplifies it by using the basic version. The contributors can just add the links under the description, no need to clutter.
Spell check daily
We already had a spell-check-differential.
This adds the daily version, taken from https://github.com/autowarefoundation/autoware.universe/blob/main/.github/workflows/spell-check-daily.yaml but with updated dictionaries.
Should be useful for assessing the overall spell-check coverage.
pre-commit configs
Mainly taken from autoware.universe, but including the hadolint from this repository.
It removes the
.svgfile exclusion from the config file.Past blame: https://github.com/autowarefoundation/autoware_core_universe_prototype/pull/5/files#diff-63a9c44a44acf85fea213a857769990937107cf072831e1a26808cfde9d096b9R93
I don't see a reason to exclude .svg files from pre-commit, it makes svg files more readable. I've looked for why it was excluded but it has been like this since first 5th PR to this repository. Most of the changes are just reformatted svg files.
How was this PR tested?
Notes for reviewers
None.
Effects on system behavior
None.