Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(spell-check-diff): add explicit dict-packages #5503

Merged
merged 4 commits into from
Nov 28, 2024
Merged

Conversation

xmfcx
Copy link
Contributor

@xmfcx xmfcx commented Nov 28, 2024

Description

Related section:

https://github.com/autowarefoundation/autoware-github-actions/blob/196ca1d50eef0fc7b898d85f7ccfe17b3c0e97b4/spell-check/action.yaml#L12-L17

  dict-packages:
    description: ""
    required: false
    default: |
      https://github.com/tier4/autoware-spell-check-dict
      https://github.com/tier4/cspell-dicts

These packages are being installed by https://github.com/autowarefoundation/autoware-github-actions/blob/196ca1d50eef0fc7b898d85f7ccfe17b3c0e97b4/spell-check/action.yaml#L32 as npm packages.

This PR adds the correct repository links.

How was this PR tested?

Notes for reviewers

None.

Effects on system behavior

None.

Copy link

github-actions bot commented Nov 28, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@xmfcx xmfcx requested a review from mitsudome-r November 28, 2024 11:42
@xmfcx xmfcx force-pushed the ci/spell-check-dicts branch from 15f4ebd to 29fb8d5 Compare November 28, 2024 11:43
@xmfcx xmfcx self-assigned this Nov 28, 2024
@xmfcx xmfcx added the tag:run-health-check Run health-check label Nov 28, 2024
@xmfcx xmfcx marked this pull request as draft November 28, 2024 11:45
Signed-off-by: M. Fatih Cırıt <[email protected]>
Signed-off-by: M. Fatih Cırıt <[email protected]>
Signed-off-by: M. Fatih Cırıt <[email protected]>
@xmfcx
Copy link
Contributor Author

xmfcx commented Nov 28, 2024

https://github.com/streetsidesoftware/cspell-dicts/tree/main/dictionaries/en_US#note

This dictionary comes pre-installed with cspell. It should not be necessary to add it.

Removed the default dictionaries.

This PR is now overriding only https://github.com/autowarefoundation/autoware-spell-check-dict

@xmfcx xmfcx marked this pull request as ready for review November 28, 2024 11:55
@xmfcx xmfcx merged commit 897faaf into main Nov 28, 2024
17 of 18 checks passed
@xmfcx xmfcx deleted the ci/spell-check-dicts branch November 28, 2024 12:01
youtalk added a commit to youtalk/autoware that referenced this pull request Nov 29, 2024
* feat(docker): inherit `autoware-base`  images (autowarefoundation#5492)

* change run

Signed-off-by: Yutaka Kondo <[email protected]>

* use autoware-base images

Signed-off-by: Yutaka Kondo <[email protected]>

* update health-check

Signed-off-by: Yutaka Kondo <[email protected]>

* update load-env

Signed-off-by: Yutaka Kondo <[email protected]>

* update load-env

Signed-off-by: Yutaka Kondo <[email protected]>

* fix rebase

Signed-off-by: Yutaka Kondo <[email protected]>

* add build-args

Signed-off-by: Yutaka Kondo <[email protected]>

* fix hcl

Signed-off-by: Yutaka Kondo <[email protected]>

---------

Signed-off-by: Yutaka Kondo <[email protected]>

* chore(autoware.repos): fix `autoware.universe` and `autoware_launch` versions to `0.39.0` (autowarefoundation#5479)

* ci: update the pr template and add comment-on-pr workflow (autowarefoundation#5500)

Signed-off-by: M. Fatih Cırıt <[email protected]>

* ci(spell-check): switch the repository to autowarefoundation (autowarefoundation#5501)

Signed-off-by: M. Fatih Cırıt <[email protected]>

* ci(pre-commit-ansible): autoupdate (autowarefoundation#5217)

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions <[email protected]>

* ci(spell-check-diff): add explicit dict-packages (autowarefoundation#5503)

Signed-off-by: M. Fatih Cırıt <[email protected]>

* refactor(docker): fix `Dockerfile` indent (autowarefoundation#5495)

fix indent

Signed-off-by: Yutaka Kondo <[email protected]>

* feat(docker): update cleanup scripts (autowarefoundation#5497)

* update cleanup scripts

Signed-off-by: Yutaka Kondo <[email protected]>

* revert to ubuntu-22.04

Signed-off-by: Yutaka Kondo <[email protected]>

---------

Signed-off-by: Yutaka Kondo <[email protected]>

* ci(sync-files): make use of sync-files-templates repo (autowarefoundation#5504)

Signed-off-by: M. Fatih Cırıt <[email protected]>

---------

Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: M. Fatih Cırıt <[email protected]>
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: M. Fatih Cırıt <[email protected]>
Co-authored-by: awf-autoware-bot[bot] <94889083+awf-autoware-bot[bot]@users.noreply.github.com>
Co-authored-by: github-actions <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tag:run-health-check Run health-check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants