Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docker): fix cleanup_apt.sh #5467

Merged
merged 5 commits into from
Nov 21, 2024
Merged

fix(docker): fix cleanup_apt.sh #5467

merged 5 commits into from
Nov 21, 2024

Conversation

youtalk
Copy link
Member

@youtalk youtalk commented Nov 21, 2024

Description

There was a bug in the handling of arguments in cleanup_apt.sh in #5447. This PR fixes it.
This resolves the unintended increase in container image sizes.

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

youtalk and others added 5 commits November 21, 2024 15:44
@youtalk youtalk self-assigned this Nov 21, 2024
@youtalk youtalk added type:containers Docker containers, containerization of components, or container orchestration. component:openadkit Issues or Features related to Open AD Kit tag:run-health-check Run health-check labels Nov 21, 2024
@youtalk youtalk marked this pull request as ready for review November 21, 2024 06:50
@youtalk youtalk requested review from xmfcx and mitsudome-r November 21, 2024 06:50
@youtalk youtalk enabled auto-merge (squash) November 21, 2024 06:54
@youtalk youtalk merged commit ef74e19 into main Nov 21, 2024
37 of 38 checks passed
@youtalk youtalk deleted the fix-cleanup-apt branch November 21, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:openadkit Issues or Features related to Open AD Kit tag:run-health-check Run health-check type:containers Docker containers, containerization of components, or container orchestration.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants