Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(clang-tidy): use minimum clang-tidy configuration for CI #5465

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

veqcc
Copy link
Contributor

@veqcc veqcc commented Nov 21, 2024

Description

This PR changes .clang-tidy-ci file to a really minimum one like the following.
Our first goal is that all the Autoware packages pass this minimum clang-tidy check and enable it as a required CI.

Checks: "
  -*,
  bugprone-dangling-handle"

WarningsAsErrors: "*"

ExtraArgs:
  - -std=c++17
  - -Wno-c11-extensions

Since clang-tidy needs at least one enabled check, I chose bugprone-dangling-handle as a first check, which is also enabled in the current Autoware.

-std=c++17 and -Wno-c11-extensions are specified so that clang-tidy can recognize C++17 new features and C++ extensions.

Related links

Autoware Discussion: https://github.com/orgs/autowarefoundation/discussions/4876#discussioncomment-11287411

Interface changes

ROS Topic Changes

ROS Parameter Changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@veqcc veqcc requested a review from mitsudome-r as a code owner November 21, 2024 03:35
@veqcc veqcc self-assigned this Nov 21, 2024
@veqcc veqcc requested a review from xmfcx November 21, 2024 03:39
@veqcc
Copy link
Contributor Author

veqcc commented Nov 21, 2024

I will wait @xmfcx 's approval 👍

Copy link
Contributor

@xmfcx xmfcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to start somewhere, thanks @veqcc

@veqcc
Copy link
Contributor Author

veqcc commented Nov 21, 2024

@xmfcx @mitsudome-r
Could someone merge it instead of me? I have no right to it
Screenshot 2024-11-21 at 17 31 16

@xmfcx xmfcx merged commit f3d27bf into autowarefoundation:main Nov 21, 2024
20 checks passed
@veqcc veqcc deleted the fix/clang-tidy-ci branch November 21, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants