-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add single lidar sensor kit #4988
feat: add single lidar sensor kit #4988
Conversation
@youtalk -san, we have an error here:
|
Signed-off-by: beginningfan <[email protected]>
7894fb6
to
15bee06
Compare
https://github.com/autowarefoundation/autoware/actions/runs/9999203274/job/27639752909?pr=4988 @youtalk -san, this is still failing even after the rebase. Maybe forks cannot make use the build cache? What can we do?
If it's failing because of the fork, we should find a way to make it work with them. PRs from forks should be able to pass required workflows. |
I see and will conduct a replication experiment to determine the cause. |
I could conduct the replication. #5015 I think the If a PR owner has no writable permission to this repository, they cannot run the CIs. @xmfcx @mitsudome-r Please make a |
@youtalk san, thanks for confirming the issue.
Well, public forks cannot access to the upstream repo's secrets due to security concerns. It is possible to make it with I'd rather not let forks to have write access to the container registry. An attacker could use it to write unwanted images to our registry by just modifying the workflow file. Why do we allow the cache to be updated when something is not merged yet? During the PR runs, before the PR is merged, nothing should be written to the cache. What do you think? |
This is a better alternative. I will do it next weekday. Please wait a while. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I've updated the branch to resolve the health-check
issue.
* feat(ci): disable `cache-to` option to run `health-check` from forked branch (autowarefoundation#5021) disable cache-to Signed-off-by: Yutaka Kondo <[email protected]> * feat: add single lidar sensor kit (autowarefoundation#4988) feat(autoware.repos): add single lidar sensor kit Signed-off-by: beginningfan <[email protected]> Co-authored-by: Yutaka Kondo <[email protected]> * fix(docker-build): fix ccache typo (autowarefoundation#5024) Signed-off-by: mitsudome-r <[email protected]> * feat(docker): no longer download artifacts on `devel` image (autowarefoundation#5023) not download artifacts on devel Signed-off-by: Yutaka Kondo <[email protected]> --------- Signed-off-by: Yutaka Kondo <[email protected]> Signed-off-by: beginningfan <[email protected]> Signed-off-by: mitsudome-r <[email protected]> Co-authored-by: beginningfan <[email protected]> Co-authored-by: Ryohsuke Mitsudome <[email protected]>
Description
Add single
lidar sensor kit
intoautoware.repos
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.