Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wrong option in setup-dev-env.sh #4039

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

HansRobo
Copy link
Member

@HansRobo HansRobo commented Dec 6, 2023

Description

install_cuda_drivers, one of extra-vars passed to ansible, is unused now.
Alternatively, cuda_install_drivers is used in cuda role.
ref: https://github.com/autowarefoundation/autoware/blob/main/ansible/roles/cuda/tasks/main.yaml#L57

Tests performed

In my local test, the command ./setup-dev-env.sh --no-cuda-drivers shows skipping: [localhost] for task autoware.dev_env.cuda : Install cuda-drivers.

Effects on system behavior

Behavor of --no-cuda-drivers option for setup-dev-env.sh

Before
./setup-dev-env.sh : install cuda-drivers
./setup-dev-env.sh --no-cuda-drivers : install cuda-drivers

After
./setup-dev-env.sh : install cuda-drivers
./setup-dev-env.sh --no-cuda-drivers : skip installing cuda-drivers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@HansRobo HansRobo marked this pull request as ready for review December 6, 2023 12:59
@HansRobo HansRobo changed the title fix: fix wrong option in setup-dev-env.sh fix: wrong option in setup-dev-env.sh Dec 6, 2023
@HansRobo HansRobo requested review from xmfcx and mitsudome-r December 6, 2023 13:02
@xmfcx xmfcx requested review from esteve and lexavtanke December 6, 2023 13:57
@xmfcx
Copy link
Contributor

xmfcx commented Dec 6, 2023

I think this is from when I renamed the variables.

It seems this variable got away somehow. Sorry for my mistake.

@xmfcx xmfcx merged commit d4dccbc into autowarefoundation:main Dec 6, 2023
19 checks passed
@HansRobo HansRobo deleted the patch-1 branch December 6, 2023 15:32
oguzkaganozt pushed a commit that referenced this pull request Feb 19, 2024
Signed-off-by: Kotaro Yoshimoto <[email protected]>
Signed-off-by: Oguz Ozturk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants