fix: wrong option in setup-dev-env.sh #4039
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
install_cuda_drivers
, one of extra-vars passed to ansible, is unused now.Alternatively,
cuda_install_drivers
is used incuda
role.ref: https://github.com/autowarefoundation/autoware/blob/main/ansible/roles/cuda/tasks/main.yaml#L57
Tests performed
In my local test, the command
./setup-dev-env.sh --no-cuda-drivers
showsskipping: [localhost]
for taskautoware.dev_env.cuda : Install cuda-drivers
.Effects on system behavior
Behavor of
--no-cuda-drivers
option forsetup-dev-env.sh
Before
./setup-dev-env.sh
: install cuda-drivers./setup-dev-env.sh --no-cuda-drivers
: install cuda-driversAfter
./setup-dev-env.sh
: install cuda-drivers./setup-dev-env.sh --no-cuda-drivers
: skip installing cuda-driversPre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.