docs: add review tips #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenji-miyake
force-pushed
the
add-pull-request-guidelines
branch
from
4f598c8
to
dedae70
Compare
Base automatically changed from
add-pull-request-guidelines
to
add-support-guidelines
March 9, 2022 09:24
added 2 commits
March 9, 2022 18:26
Signed-off-by: Kenji Miyake <[email protected]>
Signed-off-by: Kenji Miyake <[email protected]>
kenji-miyake
force-pushed
the
add-review-tips
branch
from
ae5193e
to
641e103
Compare
kenji-miyake
force-pushed
the
add-support-guidelines
branch
from
28f28a2
to
ae7fe87
Compare
isamu-takagi
previously approved these changes
Mar 9, 2022
xmfcx
approved these changes
Mar 11, 2022
There was a problem hiding this comment.
@kenji-miyake thanks for all the work. Let's merge this and we can iterate over it as we proceed.
isamu-takagi
added a commit
to isamu-takagi/autoware-documentation
that referenced
this pull request
Nov 28, 2024
Signed-off-by: Takagi, Isamu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #6