-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GPU plotting preparation #3004
GPU plotting preparation #3004
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like there are some "invalid Scalar" errors in the tests, but I can't find where they are coming from in the code changes. Maybe they're from a dependency change?
Yeah, looks like caused by |
And here is the reason: grandinetech/rust-kzg#265 |
@dariolina see ethereum/c-kzg-4844#305 and linked PRs, should we switch to big-endian encoding after Gemini 3h as well? |
f4a622e
to
d38bf1d
Compare
Ugh... |
KZG parameters are irrelevant here, this is about data processing during archiving and plotting |
Then that data processing where the endianess matters is not part of consensus, so it depends if you have counter-arguments why not switch? |
I do not have any counter-arguments, but we can only do that after Gemini 3h |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, but I don't have enough context to fully approve.
Some changes extracted from local branch that will be helpful for GPU plotting when it is introduced.
rust-kzg
repo update is needed to include grandinetech/rust-kzg#263 that we'll be using in FFI calls to GPU.K constant was not previously explicitly exposed for proof of space and pool plotter will allow us to combine CPU and GPU plotters into one virtual plotter.
Code contributor checklist: