Login in the browser when possible #50
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noahho
reviewed
Dec 11, 2024
|
|
||
| return received_token is not None, received_token | ||
|
|
||
| except Exception: |
There was a problem hiding this comment.
Can you provide more info on how this could fail? Is there e.g. times when the user doesn't have gui? in which situations might it be more comfortable in the cli?
There was a problem hiding this comment.
The main thing I had in mind is when the user is on a remote cluster. (in this case, there could also be a different workflow where we give the user the url and ask the user to paste the access token once he's logged in)
| @@ -8,6 +8,7 @@ protocol: "https" | |||
| host: "tabpfn-server-wjedmz7r5a-ez.a.run.app" | |||
| # host: tabpfn-server-preprod-wjedmz7r5a-ez.a.run.app # preprod | |||
| port: "443" | |||
There was a problem hiding this comment.
Before merging the PR change the logo and title of the UI
There was a problem hiding this comment.
|
Right now the user is getting a message on the wesbite saying he's logged
in and inviting him to go back to his code, do you mean a different thing?
…On Mon, Dec 16, 2024, 12:53 SamuelGabriel ***@***.***> wrote:
Do you think we could hint the user that they are already logged in on the
website? Or ideally somehow get the computer to focus on the terminal again?
—
Reply to this email directly, view it on GitHub
<#50 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AK46V2BKFAHONQCAOIP27232F25KJAVCNFSM6AAAAABTMDWWF6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNBVGQYTQMRZHA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Try to be precise. You can additionally add comments to your PR, this might help the reviewer a lot.
To login or register, we now default to trying to open the browser to login directly on the UI. If it's not possible, we fall back to the CLI login. Quick video demo.
Failing CI tests probably related to #49
If you used new dependencies: Did you add them to
requirements.txt?No
Who did you ping on Mattermost to review your PR? Please ping that person again whenever you are ready for another review.
Breaking changes
If you made any breaking changes, please update the version number.
Breaking changes are totally fine, we just need to make sure to keep the users informed and the server in sync.
Does this PR break the API? If so, what is the corresponding server commit?
No
Does this PR break the user interface? If so, why?
Yes, the login/register flow is different.
Please do not mark comments/conversations as resolved unless you are the assigned reviewer. This helps maintain clarity during the review process.