Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor init #29

Merged
merged 10 commits into from
Jul 4, 2024
Merged

Refactor init #29

merged 10 commits into from
Jul 4, 2024

Conversation

anshulg954
Copy link
Collaborator

Change Description

Try to be precise. You can additionally add comments to your PR, this might help the reviewer a lot.
Improvised Frontend Flow as per https://www.notion.so/f1947949ba2a4fd099b0a6f899b44fb2?v=1fecb5dd4b3a49568754a3679a76ff52&p=e0c9c65223924a47a5babe1d2b1342bd&pm=s

DFD Diagram of Implementation:
image
TabPFN Client.pdf

If you used new dependencies: Did you add them to requirements.txt?
No new dependency added.

Who did you ping on Mattermost to review your PR? Please ping that person again whenever you are ready for another review.
@SamuelGabriel

Breaking changes

If you made any breaking changes, please update the version number.
Breaking changes are totally fine, we just need to make sure to keep the users informed and the server in sync.

Does this PR break the API? If so, what is the corresponding server commit?
Nope.

Does this PR break the user interface? If so, why?
Nope. It fixes the entire workflow.

Please do not mark comments/conversations as resolved unless you are the assigned reviewer. This helps maintain clarity during the review process.

@anshulg954 anshulg954 added enhancement New feature or request good first issue Good for newcomers labels Jun 22, 2024
Copy link
Collaborator

@SamuelGabriel SamuelGabriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR. There are a few things that can be improved but this is a good direction :)

tabpfn_client/client.py Outdated Show resolved Hide resolved
tabpfn_client/service_wrapper.py Outdated Show resolved Hide resolved
tabpfn_client/config.py Outdated Show resolved Hide resolved
tabpfn_client/prompt_agent.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@SamuelGabriel SamuelGabriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SamuelGabriel SamuelGabriel merged commit b14cb11 into main Jul 4, 2024
2 checks passed
@SamuelGabriel SamuelGabriel deleted the refactor_init branch July 4, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants