Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate pipeline space into run args yaml + new design for defining constant parameter #96

Merged
merged 14 commits into from
May 27, 2024
Merged

Integrate pipeline space into run args yaml + new design for defining constant parameter #96

merged 14 commits into from
May 27, 2024

Conversation

danrgll
Copy link
Collaborator

@danrgll danrgll commented May 16, 2024 •
edited

  • Declarative usage doc changes
  • Define pipeline space in run args yaml
  • New design for constant parameter (const1: value)
  • Adapt search_space_from_yaml code to new functionalities

@danrgll danrgll changed the title [WIP]Integrate pipeline space into run args yaml [WIP]Integrate pipeline space into run args yaml + new design for defining constant parameter May 17, 2024
@danrgll danrgll changed the title [WIP]Integrate pipeline space into run args yaml + new design for defining constant parameter Integrate pipeline space into run args yaml + new design for defining constant parameter May 23, 2024
@danrgll danrgll requested a review from eddiebergman May 23, 2024 11:08
eddiebergman
eddiebergman approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@eddiebergman eddiebergman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I left some minor commentary which I'm not going to block anything on. Seems things are a lot more concise and much easier to read, nice one!

The one thing I haven't done is render the docs yet (bad internet), I will do so tomorrow and scroll through it. If all is good, I will merge!

neps/search_spaces/search_space.py Show resolved Hide resolved
neps/search_spaces/search_space.py Show resolved Hide resolved
neps/search_spaces/yaml_search_space_utils.py Show resolved Hide resolved
neps/utils/run_args_from_yaml.py Show resolved Hide resolved
@eddiebergman eddiebergman merged commit 6635010 into master May 27, 2024
11 of 13 checks passed
@danrgll danrgll mentioned this pull request Jun 4, 2024
Closed
@danrgll danrgll changed the title Integrate pipeline space into run args yaml + new design for defining constant parameter Integrate pipeline space into run args yaml + new design for defining constant parameter + new design for searcher config (yaml) Jun 5, 2024
@danrgll danrgll changed the title Integrate pipeline space into run args yaml + new design for defining constant parameter + new design for searcher config (yaml) Integrate pipeline space into run args yaml + new design for defining constant parameter Jun 5, 2024
@danrgll danrgll deleted the integrate-pipeline-space-into-run-args-yaml branch June 7, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddiebergman eddiebergman eddiebergman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danrgll @eddiebergman