optim(graph): Minor optimizations to examples using graph parameters #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Further work to decrease the time it takes to run all tests.
Running the full suite now takes ~3 minutes, down from the original ~9 minutes before the optimizations from #94. Running just
pytestnow only takes 25 seconds, which excludes the examples we run on ci.Main bottlencks for the ci are really just the construction of nx.Graphs and graph kernels which I don't think I will spend time towards. The
neps_loggertutorial is also one of the slowest tests by far since it trains an actual model, downloading MNIST to do so.Might be better to replace this with some fake data and a simple 1 linear network, although I suppose the images are required for the tutorial. I think we can just live with this being on CI.
Also did some work on CI to cut out the constant re-installing of packages. Will use
pyproject.tomlas an identity to whether it should re-use a previous environment. Damn you pytorch installs being so long...One issue however is that apparently that cache sizes for the linux poetry venvs are close to ~2GB, while for MAC and Windows it seems to be about ~300MB. My guess this is something to do with Torch but no idea how to fix this.