Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove neps argument 'searcher_path' and yaml argument searcher_kwargs + New loading design for optimizer #105

Merged
merged 30 commits into from
Jun 21, 2024

Conversation

danrgll
Copy link
Collaborator

@danrgll danrgll commented Jun 7, 2024

@danrgll danrgll changed the title Remove neps argument 'searcher_path'-New loading design for optimizer Remove neps argument 'searcher_path' + New loading design for optimizer Jun 7, 2024
@danrgll danrgll changed the title Remove neps argument 'searcher_path' + New loading design for optimizer [WIP] Remove neps argument 'searcher_path' + New loading design for optimizer Jun 7, 2024
@danrgll danrgll changed the title [WIP] Remove neps argument 'searcher_path' + New loading design for optimizer [WIP] Remove neps argument 'searcher_path' and yaml argument searcher_kwargs + New loading design for optimizer Jun 14, 2024
@danrgll danrgll self-assigned this Jun 17, 2024
@danrgll danrgll added the enhancement New feature or request label Jun 19, 2024
@danrgll danrgll added this to the Declaritive milestone Jun 19, 2024
@danrgll danrgll changed the title [WIP] Remove neps argument 'searcher_path' and yaml argument searcher_kwargs + New loading design for optimizer Remove neps argument 'searcher_path' and yaml argument searcher_kwargs + New loading design for optimizer Jun 19, 2024
Copy link
Contributor

@eddiebergman eddiebergman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as a far as I can see (hard to validate strings everywhere tbh)

One bug that needs fixing, rest is fine!

docs/doc_yamls/full_configuration_template.yaml Outdated Show resolved Hide resolved
tests/test_neps_api/testing_scripts/user_yaml_neps.py Outdated Show resolved Hide resolved
@eddiebergman
Copy link
Contributor

eddiebergman commented Jun 19, 2024

Seems like the test failures here were fixed by @karibbov in ade69db , many thanks :)

@danrgll danrgll merged commit 6a6c0c2 into master Jun 21, 2024
13 checks passed
@danrgll danrgll deleted the new-optimizer-yaml-design branch June 21, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants