1174 replace hard coded indices in runhistory #1180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjamc
reviewed
Dec 14, 2024
smac/runhistory/runhistory.py
Outdated
| ] | ||
|
|
||
| config_ids_to_serialize = set([entry[0] for entry in data]) | ||
| data[k.config_id] = { |
There was a problem hiding this comment.
this might need to be adapted
benjamc
reviewed
Dec 14, 2024
smac/runhistory/runhistory.py
Outdated
| self.add( | ||
| config=self._ids_config[int(entry[0])], | ||
| config=self._ids_config[int(key)], |
There was a problem hiding this comment.
this might need to be adapted
benjamc
requested changes
Dec 14, 2024
| 1733133181.21695, # end_time | ||
| {} # additional_info | ||
| ], | ||
| "data": { |
There was a problem hiding this comment.
AFAIK the config id is a unique configuration without the budget and the instance. If this is the case, we need a different data structure, because currently we would overwrite evaluated trials with the same configs but different budgets/instances. I would propose a list of dictionaries.
There was a problem hiding this comment.
I will check that and get back to you
There was a problem hiding this comment.
I will adapt this accordingly
|
also please update |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.