Bugfix for problematic typecheck when creating Integer #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When creating a UniformIntHyperparameter, the default_value is parsed as an int to the uniformFloatHyperparameter, which causes the type_check in line 62 to fail. This is obviously a bug. This type conversion should fix the bug.
|
Hi @Ultrahero , Appreciate the PR but in #346 we've fixed a lot of bugs and just waiting for some more review before releasing. I will close this PR as a result but thank you again for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a UniformIntHyperparameter, the default_value is parsed as an int to the uniformFloatHyperparameter, which causes the type_check in line 62 to fail.
This is obviously a bug. This type conversion should fix the bug.