Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring base dataset splitting functions #106

Merged
merged 17 commits into from
Apr 28, 2021
Merged

Refactoring base dataset splitting functions #106

merged 17 commits into from
Apr 28, 2021

Commits on Apr 14, 2021

  1. [Fork from automl#105] Made CrossValFuncs and HoldOutFuncs class to g… 

    …roup the functions
    @nabenabe0928
    nabenabe0928 committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    f204670 View commit details
    Browse the repository at this point in the history

  2. Modified time_series_dataset.py to be compatible with resampling_stra… 

    …tegy.py
    @nabenabe0928
    nabenabe0928 committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    c22ec53 View commit details
    Browse the repository at this point in the history

  3. [fix]: back to the renamed version of CROSS_VAL_FN from temporal Spli… 

    …tFunc typing.
    @nabenabe0928
    nabenabe0928 committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    bfd1a83 View commit details
    Browse the repository at this point in the history

  4. fixed flake8 issues in three files

    @nabenabe0928
    nabenabe0928 committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    4be32b3 View commit details
    Browse the repository at this point in the history

  5. fixed the flake8 issues

    @nabenabe0928
    nabenabe0928 committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    5284a84 View commit details
    Browse the repository at this point in the history

  6. [refactor] Address the francisco's comments

    @nabenabe0928
    nabenabe0928 committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    dbe7ca6 View commit details
    Browse the repository at this point in the history

  7. [refactor] Adress the francisco's comments

    @nabenabe0928
    nabenabe0928 committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    594bfaa View commit details
    Browse the repository at this point in the history

  8. [refactor] Address the doc-string issue in TransformSubset class

    @nabenabe0928
    nabenabe0928 committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    a8981a9 View commit details
    Browse the repository at this point in the history

  9. [fix] Address flake8 issues

    @nabenabe0928
    nabenabe0928 committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    e27b46f View commit details
    Browse the repository at this point in the history

  10. [fix] Fix flake8 issue

    @nabenabe0928
    nabenabe0928 committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    6b28b42 View commit details
    Browse the repository at this point in the history

  11. [fix] Fix mypy issues raised by github check

    @nabenabe0928
    nabenabe0928 committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    96e2bb0 View commit details
    Browse the repository at this point in the history

  12. [fix] Fix a mypy issue

    @nabenabe0928
    nabenabe0928 committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    0629efe View commit details
    Browse the repository at this point in the history

  13. [fix] Fix a contradiction in holdout_stratified_validation 

    Since stratified splitting requires to shuffle by default
and it raises error in the github check,
I fixed this issue.
    @nabenabe0928
    nabenabe0928 committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    d20c1b5 View commit details
    Browse the repository at this point in the history

  14. [fix] Address the francisco's review

    @nabenabe0928
    nabenabe0928 committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    244a23e View commit details
    Browse the repository at this point in the history

  15. [fix] Fix a mypy issue tabular_dataset.py

    @nabenabe0928
    nabenabe0928 committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    988a3a2 View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2021

  1. [fix] Address the francisco's comment about the self.dataset_name 

    Since we would to use the dataset name which does not have any name,
I decided to get self.dataset_name back to Optional[str].
    @nabenabe0928
    nabenabe0928 committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    70d7d60 View commit details
    Browse the repository at this point in the history

  2. [fix] Fix mypy issues

    @nabenabe0928
    nabenabe0928 committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    1c6dc23 View commit details
    Browse the repository at this point in the history