-
Notifications
You must be signed in to change notification settings - Fork 35
breaking: Clean up deprecated functionality for v1 #562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #562 +/- ##
==========================================
+ Coverage 39.28% 40.22% +0.94%
==========================================
Files 37 37
Lines 5448 5439 -9
==========================================
+ Hits 2140 2188 +48
+ Misses 3063 3001 -62
- Partials 245 250 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
54f4359
to
f54b029
Compare
registerConsistencyFlags(checkCmd.Flags()) | ||
|
||
permissionCmd.AddCommand(checkBulkCmd) | ||
checkBulkCmd.Flags().String("revision", "", "optional revision at which to check") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this one wasn't marked as hidden, can we actually remove it?
i also see this
readCmd.Flags().String("revision", "", "optional revision at which to check")
_ = readCmd.Flags().MarkHidden("revision")
I wonder if we could take this PR as an opportunity to:
This would be in the name of consistency 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran mage gen:docForPublish
and inspected the docs at https://github.com/authzed/zed/blob/main/docs/zed.md. I saw this, can we update it?
Lines 97 to 101 in 57fdb03
Example: ` | |
Write to stdout: | |
zed preview schema compile root.zed | |
Write to an output file: | |
zed preview schema compile root.zed --out compiled.zed |
Description
Part of getting a v1 of Zed out the door. We want to take the opportunity to get rid of some deprecated codepaths, which will keep complexity down in the long term.
Changes
zed preview schema compile
- it's now justzed schema compile
zed watch
- it's now justzed relationship watch
revision
flag - use the other consistency flagszed permission lookup
- it'szed permission lookup-resources
estimated-count
flag onbulk-delete
- uselimit
insteadTesting
Review. See that tests still pass.