fix: delete options not being passed #1784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
ryaneorth
force-pushed
the
fix-observable-delete-options
branch
from
0e59ba3
to
640f054
Compare
|
I have read the CLA Document and I hereby sign the CLA |
|
/recheck |
|
recheck |
|
@ryaneorth Please add a test for this case |
ryaneorth
force-pushed
the
fix-observable-delete-options
branch
from
640f054
to
c152814
Compare
|
I have read the CLA Document and I hereby sign the CLA |
|
recheck |
github-actions
bot
added
the
area/tooling
ryaneorth
commented
Mar 6, 2024
|
|
||
| type observableTest struct{} | ||
|
|
||
| func (obs observableTest) New(revisionQuantization, _, gcWindow time.Duration, watchBufferLength uint16) (datastore.Datastore, error) { |
There was a problem hiding this comment.
Adding this makes it so we test all of the Datastore tests with the Observable proxy, and more specifically the DeleteWithLimitTest which verifies the fix in this PR
|
@josephschorr - added tests |
josephschorr
approved these changes
Mar 6, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
...options.DeleteOptionsOptionare not being passed to the readwrite transaction through observable so delete limits are not honored