-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move health check logs to debug level #1773
Conversation
647fe09
to
a1410e2
Compare
Maybe we can set it so it only occurs when debug logging is set? When you first run something, it's super helpful to know if the healthcheck is reachable. |
a1410e2
to
fef91fd
Compare
fef91fd
to
e8775a9
Compare
@jzelinskie please have another look. health check calls are now moved to debug level. It's not great because grpc middleware does not have native support for something like this, but the proposed approach gets the job done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, though we'll want to test this and make sure everything logs as intended
fede7a1
to
10989b1
Compare
@ecordell thanks for the review 🙏🏻 I had already done tests locally for verification 👍🏻 I noticed #1772 did not propagate the |
10989b1
to
07905d2
Compare
they introduce noise in SpiceDB logs
07905d2
to
c845be0
Compare
The gRPC health check endpoint tends to cause noise in SpiceDB logs. This PR changes how the grpc log Middleware is installed so the grpc health route is logged at debug level.