Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduces chunking allocations for wide relations #1751

Merged
merged 1 commit into from
Feb 23, 2024

Commits on Feb 23, 2024

  1. reduces chunking allocations for wide relations

    For most situations, when the number of elements to dispatch
    is below the default 100 elements, the slice with elements
    to dispatch was appropriately pre-allocated.
    
    However, when dispatching large number of elements, the
    silence will grow from 1 up to the number of chunks, causing
    wasteful allocations in the critical path.
    
    To simplify the logic, +1 is added to account for the situation
    the number of elements is less than the chunk size. For values
    above that it will cause one excess slice entry allocation, but seems
    like a reasonable tradeoff w.r.t extra annoying code to handle it.
    vroldanbet committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    1d46c13 View commit details
    Browse the repository at this point in the history