[IAMRISK-3553] Swapped CAPTCHA on each reload #2558
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2558 +/- ##
==========================================
- Coverage 42.35% 42.13% -0.22%
==========================================
Files 120 120
Lines 3081 3116 +35
Branches 335 335
==========================================
+ Hits 1305 1313 +8
- Misses 1682 1710 +28
+ Partials 94 93 -1 ☔ View full report in Codecov by Sentry. |
|
Hi @Treterten, Can you add some tests for the changes made ? |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "auth0-lock", | |||
| "version": "12.5.0", | |||
| "version": "12.5.1", | |||
There was a problem hiding this comment.
Can we revert this please? We do not bump versions in feature PRs.
| @@ -1,12 +1,12 @@ | |||
| { | |||
| "name": "auth0-lock", | |||
| "version": "12.5.0", | |||
| "version": "12.5.1", | |||
There was a problem hiding this comment.
Can we revert this please? We do not bump versions in feature PRs.
| "lockfileVersion": 3, | ||
| "requires": true, | ||
| "packages": { | ||
| "": { | ||
| "name": "auth0-lock", | ||
| "version": "12.5.0", | ||
| "version": "12.5.1", |
There was a problem hiding this comment.
Can we revert this please? We do not bump versions in feature PRs.
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
### Changes Exactly the same as #2558 , but without package.json version bump. --------- Co-authored-by: Tre Moore <[email protected]> Co-authored-by: Josh Cain <[email protected]>
|
Closing this pull request because another pull request containing the same changes has been merged into the master branch. |
Changes
Updates swap code so that CAPTCHA gets swapped along with the form
References
Ticket 1
Ticket 2
Testing
This can be tested via layer0 by pulling down the changes and running through the instructions under
DEVELOPMENT.mdforTesting Lock locally through the Universal Login PageChecklist
Video of Fix
Screen.Recording.2024-05-23.at.3.46.36.PM.mov