Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Improvements to CI Workflow #2437

Merged
merged 1 commit into from
Aug 28, 2023
Merged

Conversation

evansims
Copy link
Member

@evansims evansims commented Aug 28, 2023

Changes

This pull request updates the continuous integration workflow test.yml:

  • Refine concurrency group specificity to improve efficiency. This cancels in-progress test runs when changes are committed to a pull request.
  • Rename the test's Run step to Build Package for clarity to aid in filtering branch protection rules.
  • Update checkout step to use github.event.pull_request.head.sha for pull_request_target (and github.ref for non-PR triggering events).
  • Hardcode node-version to 18 rather than use an environment variable.

References

Updates based on internal feedback and conversations.

Testing

This pull request applies improvements to the continuous integration testing for the repository but does not add any additional tests.

Checklist

@evansims evansims added the review:tiny Tiny review label Aug 28, 2023
@evansims evansims temporarily deployed to internal August 28, 2023 19:02 — with GitHub Actions Inactive
@evansims evansims temporarily deployed to internal August 28, 2023 19:03 — with GitHub Actions Inactive
@evansims evansims temporarily deployed to internal August 28, 2023 19:06 — with GitHub Actions Inactive
@evansims evansims marked this pull request as ready for review August 28, 2023 19:10
@evansims evansims requested a review from a team as a code owner August 28, 2023 19:10
@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (d93d513) 41.55% compared to head (00b6f89) 41.55%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2437   +/-   ##
=======================================
  Coverage   41.55%   41.55%           
=======================================
  Files         120      120           
  Lines        3025     3025           
  Branches      325      325           
=======================================
  Hits         1257     1257           
  Misses       1674     1674           
  Partials       94       94           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@evansims evansims added this pull request to the merge queue Aug 28, 2023
Merged via the queue into master with commit 7a6ddd3 Aug 28, 2023
10 checks passed
@evansims evansims deleted the test/ci-workflow-improvements branch August 28, 2023 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review:tiny Tiny review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants