fix:allow to only override elevated limits but merging with original config #71
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting a PR to this repository, you agree to the terms within the Auth0 Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.
Description
Fixes an error we found when providing overrides.
Problem detected: If we only provided overrides for elevated_limits, with no override for base size and/or per_x, the final configuration would not include the size and per_x.
Example:
When the override is processed, the configuration of the limit for 'awesome-key' results in:
This means that the base size and per_x for that key are
undefined
which causes an internal error.Solution
The solution is merging the override with the base configuration. If the override includes elevated configuration but NO base configuration it gets merged, resulting in:
References
Testing
Checklist