Add non-conformant-attempts stats #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds stats about the number of times the take operation returned non-conformant in the past.
dafortune
force-pushed
the
add-non-conformant-stats
branch
from
6cb8155
to
c0ed149
Compare
| @@ -26,17 +26,26 @@ elseif current[1] and tokens_per_ms == 0 then | |||
| end | |||
|
|
|||
| local enough_tokens = new_content >= tokens_to_take | |||
| local current_conformant_attempts = current[3] or 0; | |||
There was a problem hiding this comment.
I believe this should be current_non_conformant_attempts.
| -- however this approach allows to use a single "HMSET" command instead | ||
| -- HINCRBY and "HMSET" which makes the code a bit cleaner and since LUA scripts | ||
| -- runs atomically it has the same guarantees as HINCRBY | ||
| non_conformant_attempts = current_conformant_attempts + 1 |
There was a problem hiding this comment.
Should this account for tokens to take?
non_conformant_attempts = current_conformant_attempts + tokens_to_take
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds stats about the number of times the take operation returned non-conformant
in the past.