Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for node atob #149

Closed
wants to merge 1 commit into from
Closed

Conversation

frederikprijck
Copy link
Member

@frederikprijck frederikprijck commented Jul 6, 2023

Description

When running on a version of node that supports atob (16+), we use the platform instead of our polyfil.

This introduces the same coverage drop when running the tests against node, due to the fact that the polyfill no longer is used on node.

image

Note: this is a breaking change.

Testing

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not the default branch

This is done as a first step to, potentially, getting rid of the polyfill
@frederikprijck frederikprijck changed the title Migrate mocha to jest for running tests feat: add support for node atob Jul 6, 2023
@jonkoops
Copy link
Contributor

@frederikprijck this branch can probably be deleted now that the work on the beta branch has landed.

@frederikprijck frederikprijck deleted the feat/globalThis branch July 28, 2023 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants