Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arkose: run() not reset() on repeat attempts to authenticate #1443

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

skooch
Copy link

@skooch skooch commented Jun 17, 2024

Changes

Calling reset() instead of run() on the Arkose provider object breaks callbacks which prevents repeat authentication attempts with the same Auth0.js object. It now calls run() instead of reset().

Side note: As a customer, I found the JSDocs and Auth0 Docs rather lacking while trying to debug this issue. Parameters aren't present, just <optional> which is extraordinarily frustrating. There is also no information about behaviour, scope, or parameters in regards to triggerCaptcha().

Checklist

@skooch
Copy link
Author

skooch commented Jun 26, 2024

@srijonsaha Any chance of a review on this?

nandan-bhat
nandan-bhat previously approved these changes Jun 26, 2024
@nandan-bhat nandan-bhat self-requested a review June 26, 2024 07:14
@nandan-bhat nandan-bhat dismissed their stale review June 26, 2024 07:16

Dismissing this review, as I couldn't verify all the use-cases related to this change.

@skooch
Copy link
Author

skooch commented Jun 26, 2024

Thanks for responding @nandan-bhat, what use cases are missing from the tests?

@nandan-bhat
Copy link
Contributor

Hello @skooch, Thanks for your patience. I am expecting @srijonsaha to review this PR.

@nandan-bhat nandan-bhat requested review from nandan-bhat and removed request for nandan-bhat June 27, 2024 05:27
@srijonsaha
Copy link
Contributor

srijonsaha commented Jun 27, 2024

Hi @skooch could you list steps you took to reproduce your issue and anything specific about your setup? I was unable to reproduce it. Additionally, the reason for calling reset() here was to reset the Arkose challenge incase the Arkose object had already been initialized in a previous render but not call run(). run() should be called once triggerCaptcha() is fired by your event handler/hook following along with Arkose's API docs and should be the case for repeat authentication attempt as well.

https://developer.arkoselabs.com/docs/client-api#using-the-arkose-client-api

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants