[IAMRISK-2602] Add support for Arkose #1341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frederikprijck
requested changes
Oct 2, 2023
There was a problem hiding this comment.
Existing tests seem to fail, we want to ensure that's not the case.
Additionally, we should add tests that cover the new functionality, see #1312 for an example.
I see files are being removed from the dist folder, is this intentional?
srijonsaha
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
CodeQL found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
frederikprijck
requested changes
Oct 5, 2023
frederikprijck
requested changes
Oct 5, 2023
frederikprijck
requested changes
Oct 5, 2023
frederikprijck
requested changes
Oct 5, 2023
frederikprijck
previously approved these changes
Oct 6, 2023
frederikprijck
approved these changes
Oct 6, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adds support for Arkose as a captcha provider.
References
https://auth0team.atlassian.net/browse/IAMRISK-2602
Testing
arkose.mp4
Checklist