Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add meaning of isAuthenticated to FAQ #1134

Merged
merged 9 commits into from
Sep 25, 2023
Merged

Add meaning of isAuthenticated to FAQ #1134

merged 9 commits into from
Sep 25, 2023

Conversation

frederikprijck
Copy link
Member

@frederikprijck frederikprijck commented Sep 15, 2023 •
edited
Loading

Changes

With v2, the meaning of isAuthenticated has been corrected to only look at the id token.
This has been called out to be confusing, and we want to improve the experience by calling this out in our FAQ.

References

auth0/auth0-react#464

Checklist

@frederikprijck frederikprijck requested a review from a team as a code owner September 15, 2023 06:52
@frederikprijck frederikprijck temporarily deployed to internal September 15, 2023 06:52 — with GitHub Actions Inactive
@frederikprijck frederikprijck temporarily deployed to internal September 15, 2023 06:52 — with GitHub Actions Inactive
@frederikprijck frederikprijck temporarily deployed to internal September 15, 2023 06:52 — with GitHub Actions Inactive
@frederikprijck frederikprijck temporarily deployed to internal September 15, 2023 06:55 — with GitHub Actions Inactive
@frederikprijck frederikprijck temporarily deployed to internal September 15, 2023 06:55 — with GitHub Actions Inactive
@frederikprijck frederikprijck temporarily deployed to internal September 15, 2023 06:57 — with GitHub Actions Inactive
adamjmcgrath
adamjmcgrath reviewed Sep 15, 2023
View reviewed changes
FAQ.md Outdated Show resolved Hide resolved
adamjmcgrath
adamjmcgrath reviewed Sep 15, 2023
View reviewed changes
FAQ.md Outdated Show resolved Hide resolved
adamjmcgrath
adamjmcgrath reviewed Sep 15, 2023
View reviewed changes
FAQ.md Outdated Show resolved Hide resolved
@frederikprijck frederikprijck temporarily deployed to internal September 15, 2023 11:22 — with GitHub Actions Inactive
@frederikprijck frederikprijck temporarily deployed to internal September 15, 2023 11:22 — with GitHub Actions Inactive
@frederikprijck frederikprijck temporarily deployed to internal September 15, 2023 11:22 — with GitHub Actions Inactive
adamjmcgrath
adamjmcgrath reviewed Sep 15, 2023
View reviewed changes
FAQ.md Outdated Show resolved Hide resolved
@frederikprijck @adamjmcgrath
Update FAQ.md
4031b99 
Co-authored-by: Adam Mcgrath <[email protected]>
@frederikprijck frederikprijck temporarily deployed to internal September 15, 2023 11:26 — with GitHub Actions Inactive
@frederikprijck frederikprijck temporarily deployed to internal September 15, 2023 11:26 — with GitHub Actions Inactive
@frederikprijck frederikprijck temporarily deployed to internal September 15, 2023 11:28 — with GitHub Actions Inactive
@frederikprijck frederikprijck temporarily deployed to internal September 18, 2023 13:30 — with GitHub Actions Inactive
@frederikprijck frederikprijck temporarily deployed to internal September 18, 2023 13:30 — with GitHub Actions Inactive
@frederikprijck frederikprijck temporarily deployed to internal September 18, 2023 13:34 — with GitHub Actions Inactive
@frederikprijck frederikprijck temporarily deployed to internal September 19, 2023 20:16 — with GitHub Actions Inactive
@frederikprijck frederikprijck temporarily deployed to internal September 19, 2023 20:16 — with GitHub Actions Inactive
@frederikprijck frederikprijck temporarily deployed to internal September 19, 2023 20:21 — with GitHub Actions Inactive
@frederikprijck frederikprijck temporarily deployed to internal September 20, 2023 12:55 — with GitHub Actions Inactive
@frederikprijck frederikprijck temporarily deployed to internal September 20, 2023 12:55 — with GitHub Actions Inactive
@frederikprijck frederikprijck temporarily deployed to internal September 20, 2023 12:57 — with GitHub Actions Inactive
@frederikprijck frederikprijck temporarily deployed to internal September 25, 2023 10:03 — with GitHub Actions Inactive
@frederikprijck frederikprijck temporarily deployed to internal September 25, 2023 10:03 — with GitHub Actions Inactive
@frederikprijck frederikprijck temporarily deployed to internal September 25, 2023 10:03 — with GitHub Actions Inactive
ewanharris
ewanharris requested changes Sep 25, 2023
View reviewed changes
FAQ.md Outdated Show resolved Hide resolved
@frederikprijck @ewanharris
Update FAQ.md
93a71e3 
Co-authored-by: Ewan Harris <[email protected]>
@frederikprijck frederikprijck temporarily deployed to internal September 25, 2023 10:07 — with GitHub Actions Inactive
@frederikprijck frederikprijck temporarily deployed to internal September 25, 2023 10:07 — with GitHub Actions Inactive
@frederikprijck frederikprijck temporarily deployed to internal September 25, 2023 10:07 — with GitHub Actions Inactive
@frederikprijck frederikprijck merged commit 405764e into main Sep 25, 2023
17 of 18 checks passed
@frederikprijck frederikprijck deleted the frederikprijck-patch-2 branch September 25, 2023 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewanharris ewanharris ewanharris approved these changes

@adamjmcgrath adamjmcgrath Awaiting requested review from adamjmcgrath

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@frederikprijck @adamjmcgrath @ewanharris