Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace issue template with issue forms [SDK-4196] #1094

Merged
merged 2 commits into from
May 4, 2023
Merged

Conversation

Widcket
Copy link
Contributor

@Widcket Widcket commented May 3, 2023

Changes

This PR replaces the Markdown-based issue templates with issue forms. These forms are a direct conversion of the Markdown issue templates, with the addition of a checklist at the top containing links to self-serve resources.

Checklist

@Widcket Widcket added the review:small Small review label May 3, 2023
@Widcket Widcket requested a review from a team as a code owner May 3, 2023 23:30
Copy link
Member

@frederikprijck frederikprijck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, small comment/question.

attributes:
label: Framework version
validations:
required: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if there is no framework being used? Should this be optional instead, as well as the framework above?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, I've made it optional in cc8807b.

@Widcket Widcket merged commit 79720c5 into master May 4, 2023
3 checks passed
@Widcket Widcket deleted the chore/issue-forms branch May 4, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review:small Small review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants