Fix asyncify for users client where token is not required #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auth0/asyncify.py
Outdated
| @@ -21,6 +22,17 @@ def asyncify(cls): | |||
| if callable(getattr(cls, func)) and not func.startswith("_") | |||
| ] | |||
|
|
|||
| class BareAsyncClient(cls): | |||
There was a problem hiding this comment.
Thanks for this fix @cgearing! Would you mind just calling this UsersAsyncClient and I'd be happy to approve the PR
There was a problem hiding this comment.
Done! Sorry I missed your comment!
adamjmcgrath
approved these changes
Jul 24, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR fixes a bug that is currently in the Auth0 SDK
asyncifywrapper where it falls through to the AsyncManagementClient when the class being wrapped doesn't inherit from theAuthenticationBaseclass. This doesn't work for theUsersclient, as that shouldn't require a management token.Currently, using the
Usersclient with the async wrapper fails with the following error:The approach I took was to implement a new
BareAsyncClientfor this case, however I'm not 100% wedded to this approach so feel free to tell me to have another go!Testing
I've added a test for this functionality to check that we don't need to add the token when calling the Users client when wrapped in an async context.
Checklist