Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix intellisense on Auth0 class #486

Merged
merged 2 commits into from
Apr 3, 2023
Merged

Fix intellisense on Auth0 class #486

merged 2 commits into from
Apr 3, 2023

Conversation

adamjmcgrath
Copy link
Contributor

Changes

Fix Intellisense for Auth0 class

References

fixes #483

@Viicos
Copy link
Contributor

Viicos commented Apr 3, 2023

Indeed might be better than using a if TYPE_CHECKING check

@adamjmcgrath adamjmcgrath merged commit 1e2b7be into master Apr 3, 2023
@adamjmcgrath adamjmcgrath deleted the fix-intellisense branch April 3, 2023 12:07
@michaeloliverx
Copy link

It would probably help if the same fix was done on the AsyncAuth0 class.

@adamjmcgrath
Copy link
Contributor Author

Thanks for the suggestion @michaeloliverx - but every async method is generated at runtime so adding intellisense to the AsyncAuth0 class wont be overly helpful.

In a future major upgrade we will look at generating this code at build time so that we can provide intellisense for async methods (as well as some other benefits) to this SDK - but in the meantime the async methods will have to stay as they are

@adamjmcgrath adamjmcgrath mentioned this pull request Apr 3, 2023
@adamjmcgrath adamjmcgrath mentioned this pull request Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review:small Small review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Worse developer experience since introducing async support - IntelliSense doesn't work for endpoint classes
4 participants