Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to JDK 17 and JakartaEE 6.0 #138

Closed
wants to merge 4 commits into from
Closed

Conversation

TareqK
Copy link

@TareqK TareqK commented Dec 11, 2023

Changes

This is a refactor that upgrades the mvc-common library to Jakarta EE6.0 and JDK 17, allowing use on more modern servers and libraries - the tests were also fixed to account for the expiration of tokens. The main changes were to the build and namespaces of imports - with some changes to the tests using regexes.

References

solves #111

Testing

  • This change adds test coverage
  • This change has been tested on the latest version of Java or why not

Checklist

Added Context

This will break the current API as it changes all the required args to another package. Will fail CI check for API Changes - but this is expected and part of the issue.

@TareqK TareqK requested a review from a team as a code owner December 11, 2023 10:21
@TareqK
Copy link
Author

TareqK commented Dec 11, 2023

Further Context : Upgraded only to jdk17 instead of 21 because the oss-plugin didnt run with jdk 21 - and gradle support for jdk 21 is fairly new.

@jimmyjames
Copy link
Contributor

👋 hey @TareqK, thanks for the PR! This is something that we plan to do in a new major version. We may revisit this PR when work on that release begins, but it's not something we can accept right now as it would be a breaking change that would require a new major version release.

@jimmyjames jimmyjames closed this Dec 18, 2023
@nmanandhar
Copy link

hi @jimmyjames

any estimate (months or years) of when the next major version is planned for would be helpful. If it is not planned for the near future, was thinking of maintaining a fork until the fix is released, since it is blocking moving to spring boot 3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants