Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix org name validation #134

Merged
merged 1 commit into from
Jul 18, 2023
Merged

Fix org name validation #134

merged 1 commit into from
Jul 18, 2023

Conversation

jimmyjames
Copy link
Contributor

Changes

In #132, we validate the org name by using equalsIgnoreCase(), but instead we should use equals() with the provided value being lower-cased. The AS will send the claim value as lower-cased.

@jimmyjames jimmyjames added the review:tiny Tiny review label Jul 18, 2023
@jimmyjames jimmyjames requested a review from a team as a code owner July 18, 2023 12:21
@jimmyjames jimmyjames merged commit 53701f3 into master Jul 18, 2023
10 checks passed
@jimmyjames jimmyjames deleted the fix-org-name-check branch July 18, 2023 15:23
@jimmyjames jimmyjames mentioned this pull request Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review:tiny Tiny review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants