Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PATCH: Add resource server scopes to terraform import #1079

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

duedares-rvj
Copy link
Contributor

@duedares-rvj duedares-rvj commented Sep 25, 2024

The response that fetches resource servers included only 2 fields: id and name
Because of this, the scopes filed was always an empty slice and thus never populated during a terraform import.

🔧 Changes

Included scopes while fetching.

📚 References

🔬 Testing

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@duedares-rvj duedares-rvj requested a review from a team as a code owner September 25, 2024 12:44
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.05%. Comparing base (01a8ebc) to head (b248151).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1079   +/-   ##
=======================================
  Coverage   72.05%   72.05%           
=======================================
  Files          94       94           
  Lines       12938    12938           
=======================================
  Hits         9322     9322           
  Misses       3069     3069           
  Partials      547      547           
Flag Coverage Δ
72.05% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@duedares-rvj duedares-rvj self-assigned this Sep 26, 2024
@duedares-rvj duedares-rvj merged commit 5ce0e13 into main Oct 1, 2024
11 checks passed
@duedares-rvj duedares-rvj deleted the import/resource_server_scopes branch October 1, 2024 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants