test: migrated from Quick & Nimble to use XCTest to remove dependency on third party packages #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… on third party packages
Widcket
reviewed
Jun 20, 2024
Comment on lines
134
to
138
| XCTAssertThrowsError(try sut.string(forKey: "SHOULDNOTEXIST")) | ||
| } | ||
|
|
||
| func testRetrievingNonExistingDataItem() { | ||
| XCTAssertThrowsError(try sut.data(forKey: "SHOULDNOTEXIST")) |
There was a problem hiding this comment.
Is there any way to assert that the error thrown is SimpleKeychainError.itemNotFound?
There was a problem hiding this comment.
Yes, updated it to verify if the error thrown is SimpleKeychainError.itemNotFound, please take a look again
Widcket
approved these changes
Jun 21, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📋 Changes
Quick&Nimblefor unit tests in this package to use XCTest to remove dependency on third party packages✅ Checklist
🎯 Testing