Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add privacy manifest to Auth0.Swift #841

Merged
merged 10 commits into from
Apr 12, 2024
Merged

Conversation

poovamraj
Copy link
Contributor

@poovamraj poovamraj commented Apr 12, 2024

Privacy Manifest is required by Apple from May 1st. We have added this to our SDK in this PR

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

📋 Changes

  • Added PrivacyManifest file
  • PrivacyManifest includes NSPrivacyCollectedDataTypeUserID with purpose as NSPrivacyCollectedDataTypePurposeAppFunctionality
  • Added it to .podspec and Package.swift

📎 References

Screenshot 2024-04-12 at 13 10 20
https://developer.apple.com/app-store/app-privacy-details/#user-tracking
https://developer.apple.com/documentation/bundleresources/privacy_manifest_files/describing_data_use_in_privacy_manifests#4144131

🎯 Testing

Repos with test integration
https://github.com/poovamraj/spm
https://github.com/poovamraj/carthage

@poovamraj poovamraj requested a review from a team as a code owner April 12, 2024 11:12
Auth0.podspec Outdated Show resolved Hide resolved
Package.swift Outdated Show resolved Hide resolved
Copy link
Contributor

@Widcket Widcket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is missing the changes needed to support apps that use Carthage to install Auth0.swift.
Did you test the changes in a sample app that uses Carthage?

@Widcket Widcket linked an issue Apr 12, 2024 that may be closed by this pull request
5 tasks
@Widcket Widcket mentioned this pull request Apr 12, 2024
2 tasks
@poovamraj poovamraj requested a review from Widcket April 12, 2024 17:46
@poovamraj poovamraj merged commit 1a0180f into master Apr 12, 2024
9 checks passed
@poovamraj poovamraj deleted the add-privacy-manifest branch April 12, 2024 17:54
@Widcket Widcket mentioned this pull request Apr 12, 2024
@wongk
Copy link

wongk commented May 3, 2024

This change is causing an error when building our application.

error: Multiple commands produce '/Users/expo/Library/Developer/Xcode/DerivedData/HealthCoach-cadkgkgehnezpjdtijikapiciihy/Build/Intermediates.noindex/ArchiveIntermediates/HealthCoach/InstallationBuildProductsLocation/Applications/HealthCoach.app/PrivacyInfo.xcprivacy'

Please see: https://stackoverflow.com/a/78344724. The podspec should use the following format:

"resource_bundles": {"LibName": "LibName/PrivacyInfo.xcprivacy"}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Privacy manifest
3 participants