feat: self-bundle is a permitted resume callback #838
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When resuming the flow, some urls can be registered by the application (ex. www.my-app.com can be registered to open <My App>), but in some cases a redirect proxy must be used like in the case of B2B2C Auth0 consumers. Such a proxy could redirect directly into the app using the identifier syntax. In accordance with "Getting Started" documentation which advises the use of "BUNDLE_IDENTIFIER.auth0://" schema urls we conditionally pass a direct and anticipated match. More simply, if the outgoing redirect is a proxy, incoming redirects could go directly into the app.
Comment on lines
+17
to
+19
| userAgent = SpyUserAgent() | ||
| handler = SpyGrant() | ||
| loggerOutput = SpyOutput() |
There was a problem hiding this comment.
note: reset mocks between test
| @@ -50,6 +54,17 @@ class LoginTransactionSpec: QuickSpec { | |||
| expect(transaction.userAgent).to(beNil()) | |||
| } | |||
|
|
|||
| it("should succeed when using bundle schema") { | |||
There was a problem hiding this comment.
note: roughly identical in implementation to "can handle"
2 tasks
|
Thank you for raising this PR and bringing about this to our notice. We are tackling this as part of #850 , hence closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📋 Changes
When resuming the flow, some urls can be registered by the application (ex. www.my-app.com can be registered to open ), but in some cases a redirect proxy must be used like in the case of B2B2C Auth0 consumers. Such a proxy could redirect directly into the app using the identifier syntax.
In accordance with "Getting Started" documentation which advises the use of "BUNDLE_IDENTIFIER.auth0://" schema urls we conditionally pass a direct and anticipated match.
More simply, if the outgoing redirect is a proxy, incoming redirects could go directly into the app.
📎 References
N/A
🎯 Testing
I was able to use xcode to test.