Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new error type to AuthenticationError #820

Merged
merged 5 commits into from
Jan 4, 2024

Conversation

lordzsolt
Copy link
Contributor

@lordzsolt lordzsolt commented Jan 4, 2024

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

📋 Changes

This PR adds new error types to AuthenticationError to match those in Auth0.Android:

  • isInvalidRefreshToken

📎 References

🎯 Testing

Test was added according to existing test specs.

@lordzsolt lordzsolt requested a review from a team as a code owner January 4, 2024 18:28
@lordzsolt lordzsolt changed the title Feature/invalid refresh token Add new error type to AuthenticationError Jan 4, 2024
let error = AuthenticationError(info: values, statusCode: 403)
expect(error.isInvalidRefreshToken) == true
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the "should not match any custom error" and "should not match any known error" test cases as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick review! Updated.

Copy link
Contributor

@Widcket Widcket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lordzsolt for the contribution! Please address the requested change and it should be ready to merge.

@lordzsolt lordzsolt requested a review from Widcket January 4, 2024 18:44
Widcket
Widcket previously approved these changes Jan 4, 2024
@Widcket Widcket enabled auto-merge (squash) January 4, 2024 18:45
@Widcket Widcket merged commit a0fe839 into auth0:master Jan 4, 2024
11 of 12 checks passed
@Widcket Widcket mentioned this pull request Mar 1, 2024
@Widcket
Copy link
Contributor

Widcket commented Mar 1, 2024

This is now out in v2.6.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants