Add support for ephemeral session in Custom Tabs #863
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for ephemeral browsing sessions in Custom Tabs, leveraging the functionality introduced in
androidx.browser:browser:1.9.0
. Ephemeral sessions enhance privacy and security by preventing the persistence of browsing data, cookies, or history during authentication flows.Features Added
CustomTabsOptions Updates
ephemeralBrowsingEnabled
field to store the ephemeral browsing preferencewithEphemeralBrowsingEnabled(boolean)
method inCustomTabsOptions.Builder
to enable/disable ephemeral browsingtoIntent()
method to callsetEphemeralBrowsingEnabled()
on theCustomTabsIntent.Builder
when the option is enabledWebAuthProvider Updates
enableEphemeralSession()
method inWebAuthProvider.Builder
to enable ephemeral browsing sessions with a simple APICustomTabsOptions
with ephemeral browsing enabled and sets it on the builderAPI Usage
Recommended Approach (Simple)
Advanced Approach (Full Control)
Benefits
Testing
CustomTabsOptionsTest.java
WebAuthProviderTest.kt
to verify theenableEphemeralSession()
methodThe implementation follows the existing patterns in the codebase and maintains complete backward compatibility. When ephemeral browsing is not explicitly enabled, the behavior remains identical to the current implementation.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
dl.google.com
/usr/lib/jvm/temurin-17-jdk-amd64/bin/java --add-opens java.base/java.util=ALL-UNNAMED --add-opens java.base/java.lang=ALL-UNNAMED --add-opens java.base/java.lang.invoke=ALL-UNNAMED --add-opens java.base/java.util=ALL-UNNAMED --add-opens java.prefs/java.util.prefs=ALL-UNNAMED --add-opens java.prefs/java.util.prefs=ALL-UNNAMED --add-opens java.base/java.nio.charset=ALL-UNNAMED --add-opens java.base/java.net=ALL-UNNAMED --add-opens java.base/java.util.concurrent.atomic=ALL-UNNAMED -Xmx2048m -Dfile.encoding=UTF-8 -Duser.country -Duser.language=en -Duser.variant -cp /home/REDACTED/.gradle/wrapper/dists/gradle-7.5-all/6qsw290k5lz422uaf8jf6m7co/gradle-7.5/lib/gradle-launcher-7.5.jar org.gradle.launcher.daemon.bootstrap.GradleDaemon 7.5
(dns block)If you need me to access, download, or install something from one of these locations, you can either:
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.