Update codeceptjs #152
Merged
Update codeceptjs #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are using an incorrect docker image that hasn't been updated for 3 years: hub.docker.com/r/codeception/codeceptjs Instead, we should be using hub.docker.com/r/codeceptjs/codeceptjs instead.
|
Marking this as draft as the latest codeceptjs/codeceptjs uses a new major version of codeceptjs which requires changes. We have applied these changes on the chore/update-deps branch for our tests. Once all samples have been updated and CI succeeds, we will merge the quickstart test changes to master and update this PR. |
ewanharris
approved these changes
Jun 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are using an incorrect docker image that hasn't been updated for 3 years: hub.docker.com/r/codeception/codeceptjs
Instead, we should be using hub.docker.com/r/codeceptjs/codeceptjs instead.