Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Updates to Workflows #5

Merged
merged 36 commits into from
Nov 8, 2023
Merged

ci: Updates to Workflows #5

merged 36 commits into from
Nov 8, 2023

Conversation

evansims
Copy link
Member

@evansims evansims commented Nov 7, 2023

This PR makes improvements to the GitHub Workflow files for the repository. The PR:

  • Adds a Snyk workflow, based on feedback from the security review.

Please ignore check failures on the existing build and semgrep workflows, as this PR modifies these. Merging this PR will resolve those for future checks.

@evansims
Copy link
Member Author

evansims commented Nov 7, 2023

@frederikprijck Sure thing, will make further adjustments once I get Snyk playing nice.

@evansims evansims marked this pull request as ready for review November 8, 2023 00:00
@evansims evansims requested a review from a team as a code owner November 8, 2023 00:00
@evansims
Copy link
Member Author

evansims commented Nov 8, 2023

@frederikprijck Alright, it should be good now, take a look when you have a moment.

Copy link
Contributor

@frederikprijck frederikprijck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks great! Just added two questions.

.github/workflows/build.yml Show resolved Hide resolved
.github/workflows/build.yml Show resolved Hide resolved
.github/workflows/snyk.yml Outdated Show resolved Hide resolved
.github/workflows/snyk.yml Outdated Show resolved Hide resolved
Co-authored-by: Frederik Prijck <[email protected]>
Co-authored-by: Frederik Prijck <[email protected]>
@frederikprijck
Copy link
Contributor

Thanks! 🚀

@frederikprijck frederikprijck merged commit 7c707eb into main Nov 8, 2023
3 checks passed
@frederikprijck frederikprijck deleted the ci/update-workflows branch November 8, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants