Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK-4362] Rewrite QS to use Django 4.2 (LTS) from 2.2 (EOL'd), and PyJWT 2.7 from 1.7 (EOL'd) #66

Merged
merged 3 commits into from
Jun 23, 2023

Conversation

evansims
Copy link
Member

@evansims evansims commented Jun 21, 2023

This PR:

  • Rewrites the quickstart to use Django 4.2 (LTS), the current recommended release. The previous example used Django 2.2, which is no longer supported. The sister quickstart to this, auth0-django-web-app, has already been updated to use 4.2.
  • Upgrades PyJWT to 2.7 (up from 1.7, which is no longer supported.)
  • 馃敀 Resolves 15 Snyk warnings from vulnerabilities in unsupported dependencies.

@adamjmcgrath I'd appreciate your input on these changes. Once I get your 馃憤 on the changes, I'll update the test suite to pass and use GitHub Actions, and update the written QS guide to match these changes.

(This is being tracked internally as SDK-4362.)

@evansims evansims added the review:small Small review label Jun 21, 2023
@evansims evansims marked this pull request as ready for review June 21, 2023 02:58
@evansims evansims requested a review from a team as a code owner June 21, 2023 02:58
@evansims evansims changed the title Rewrite QS to use Django 4.2 (LTS) from 2.2 (EOL'd), and PyJWT 2.7 from 1.7 (EOL'd) [SDK-4362] Rewrite QS to use Django 4.2 (LTS) from 2.2 (EOL'd), and PyJWT 2.7 from 1.7 (EOL'd) Jun 21, 2023
@evansims evansims added review:medium Medium review and removed review:small Small review labels Jun 22, 2023
@romanv-jazwares
Copy link

Just a question on this Pull Request, coming from someone who is looking to integrate Auth0 into an existing DRF application. This seems to drop the Django Rest Framework implementation. Are there plans to also provide an example with DRF?

@evansims
Copy link
Member Author

Hi @romanv-jazwares, thanks for taking a look!

While the current version of this QuickStart includes DRF as a dependency, as I was updating this code, I didn鈥檛 identify anything that was particularly specific (in terms of
how we鈥檙e demonstrating authorization) to DRF that justified including the dependency.

I think perhaps introducing a separate example folder specifically for DRF integration would make sense, as bandwidth allows. Given that there are just so many REST frameworks out there for Django, I think it鈥檚 good to have a minimal starter integration example that doesn鈥檛 rely on anything extra, dependency speaking.

I agree though, a separate DRF integration example would be good to offer.

@romanv-jazwares
Copy link

Thanks for the quick reply @evansims! Understood, I'll work through implementing this for our particular DRF setup. Either way, I appreciate all the work you and the rest of the team put into these!

Copy link
Contributor

@adamjmcgrath adamjmcgrath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 馃憤

@evansims evansims merged commit c2381f7 into master Jun 23, 2023
3 of 4 checks passed
@evansims evansims deleted the qs/upgrade-django branch June 23, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review:medium Medium review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants